Valid the authorized nodes in the node shared secret #715
+64
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Enum.all?( | ||
| Map.keys(authorized_keys), | ||
| &Utils.key_in_node_list?(nodes, &1) | ||
| authorized_keys |
There was a problem hiding this comment.
I think it will be more clear without the pipeline by extracting variables and do simple comparison.
…tion_and_node_renewal_are_equal_
Neylix
requested changes
Nov 29, 2022
| &Utils.key_in_node_list?(nodes, &1) | ||
| ) do | ||
| {:ok, _, _} <- NodeRenewal.decode_transaction_content(content), | ||
| true <- sorted_authorized_keys == sorted_node_renewal_authorized_keys do |
There was a problem hiding this comment.
You may add a unit test to ensure the error when both list are different.
Otherwise it works well 👍
…tion_and_node_renewal_are_equal_
Neylix
approved these changes
Nov 30, 2022
samuelmanzanera
approved these changes
Nov 30, 2022
tenmoves
added a commit
to tenmoves/archethic-node
that referenced
this pull request
Dec 6, 2022
…ation#715) * Valid the authorized nodes in the node shared secret * refactoring * added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Actually during the pending validation, we control if the new authorized nodes in the node shared secret transaction are part of the candidate, but we do not verify if the selected ones are the good ones.
We should not verify if the new authorized nodes are part of the candidate, but directly verify that all authorized nodes are the same as the return of the function NodeRenewal.next_authorized_node_public_keys()
Fixes #694
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
we make sure that the authorized nodes in the transaction are exactly the same as the ones returned by
next_authorized_node_public_keys function
Checklist: